Adds support for easy building Nextor with Docker #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for easy building Nextor with Docker
Konamiman
requested changes
Jan 22, 2025
Owner
Konamiman
left a comment
Konamiman
left a comment
There was a problem hiding this comment.
Hi @gilbertfrancois, thanks for your contribution and sorry for the long delay in looking into it. Your pull request looks interesting, however I have a couple of comments/change requests:
- First it's about the organization of the files. Instead of the
build_nextor.shscript living directly in the source of the repository, I think it could go into abuildtools/dockerdirectory. Similarly,build_builder.shand what's inside yourdockerdirectory could go inbuildtools/docker/internal. This way everything gets neatly organized and it's clear thatbuild_nextor.shis the one to run. - Instead of generating the ROMs in a
distdirectory, could them go intobin\kernels, as the current makefile does? - I see that
build_nextor.shbuilds NEXTOR.SYS and the tools too, and apparently they are copied tobin/tools, but actually they aren't. - If I run the script twice I would expect to nothing happen the second time, since no source files have changed; but actually a full rebuild is triggered again. Could this be fixed?
Let me know what you think, and thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for easy building Nextor with Docker.
Dear Konamiman,
I wanted to build the latest Nextor on my machine. However, I'm running on a mac with arm processor and saw that Linux is the preferred OS for building this project. That's why I created this docker image (for arm64 and x86_64). Maybe it is useful for other users too, running e.g. Windows, macOS or even Linux, without having the required build tools installed on their system. That is why I propose this pull request.
The only step needed to build Nextor is running the script
build_nextor.sh. The ROMs will be available in thedistdirectory after compilation.I hope you will consider merging it in your great project.
PS: It was nice to meet you in Amsterdam in december :)